Files
hyprcrd/relay/inc/routes/public.php
T
thandClaude Opus 4.7 d83de30d6d security: v2.0 — AES-GCM crypto, SSRF guards, rate limits, hardening
Breaking wire-format change: dual-read (V1+V2) / single-write (V2) so
existing user secrets, stored messages, and inter-tenant key keep
working. Old clients and relays lose cross-version chat until both
sides are upgraded.

Relay
- Switch clientEncrypt/masterEncrypt to AES-256-GCM with HKDF-derived
  per-ciphertext salts; keep CBC-V1 fallback on decrypt only.
- On-bootstrap migration re-envelopes tenant secret_encrypted and the
  inter-tenant key to GCM-V2 (idempotent).
- CORS: stop reflecting arbitrary Origin; allow own origin + optional
  RELAY_CORS_ORIGINS env allowlist; drop Access-Control-Allow-Credentials.
- Generic error messages replace "no such user: <name>" enumeration.
- Exception messages no longer echoed back; logged server-side.
- Collab-lock max hold capped at 10min so a member can't grief-refresh
  forever.
- Attachment filenames validated against hex.<ext> pattern.
- Passwords min length 10; /api/account/password rate-limited.

App / Electron client
- Shared hyprcrdRelayEncrypt/Decrypt helpers (GCM-V2 write, V1 read).
- Chat + collab-buckets plugins delegate to the shared helpers.
- Poll + push + attachments migrated to the dual-format path.
- /api/relay/settings GET returns has_key boolean; secret never echoed.
- Setup endpoint now CSRF-checked.
- SSRF: CURLOPT_PROTOCOLS restricted to HTTP(S) everywhere; bookmarks
  favicon fetch also blocks private/loopback/link-local.
- Login / password-change rate limiter moved to DB-backed IP keying.
- Passwords min length 10 throughout.
- Zip import enforces per-file (25MB) and total (500MB) caps, extension
  allowlist, no-overwrite.
- Verbose relay-push debug gated behind APP_DEBUG env.

Version bumped to 2.0.0 (protocol-breaking).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-04-17 17:02:04 +02:00

111 lines
4.5 KiB
PHP

<?php
// Public + UI session routes:
// GET /api/status
// POST /api/setup
// POST /api/login
// POST /api/logout
// GET /api/me
//
// Each handler exits on match. Falls through to other route files if
// none of these matched.
if (!defined('RELAY_BOOTSTRAPPED')) { http_response_code(404); exit; }
// ── Public: status ─────────────────────────────────────────────────
if ($route === '/api/status' && $method === 'GET') {
$data = [
'setup' => $isSetup,
'has_admin' => adminCount($db) > 0,
'has_super_secret' => hasInterTenantKey($db),
];
$sessionTenant = getSessionTenant($db);
if ($sessionTenant) {
$cnt = $db->prepare('SELECT COUNT(*) FROM messages WHERE recipient_id = :r AND fetched = 0');
$cnt->execute(['r' => $sessionTenant['id']]);
$data['logged_in'] = true;
$data['username'] = $sessionTenant['username'];
$data['is_admin'] = (bool)$sessionTenant['is_admin'];
$data['inbox_count'] = (int)$cnt->fetchColumn();
$data['has_secret'] = !empty($sessionTenant['secret_hash']);
$data['password_changed'] = (bool)$sessionTenant['password_changed'];
} else {
$data['logged_in'] = false;
}
jsonResponse($data);
}
// ── Public: setup (only when no tenants exist) ────────────────────
if ($route === '/api/setup' && $method === 'POST') {
if (isRateLimited($db, 'setup', 5)) jsonResponse(['error' => 'too many attempts'], 429);
if (!$isSetup) jsonResponse(['error' => 'already configured'], 403);
$input = json_decode(file_get_contents('php://input'), true) ?: [];
$username = trim((string)($input['username'] ?? ''));
$password = (string)($input['password'] ?? '');
$superSecret = (string)($input['super_secret'] ?? '');
if (!preg_match('/^[a-zA-Z0-9_-]{2,32}$/', $username)) {
jsonResponse(['error' => 'username must be 2-32 chars: letters, digits, _ or -'], 400);
}
if (strlen($password) < 10) jsonResponse(['error' => 'password must be at least 10 chars'], 400);
if (strlen($superSecret) < 12) jsonResponse(['error' => 'super-shared secret must be at least 12 chars'], 400);
// Create the admin tenant. NO client secret yet — the admin (and every
// user) sets that themselves later via the account view.
$passHash = password_hash($password, PASSWORD_BCRYPT);
$db->prepare('INSERT INTO tenants (username, password_hash, is_admin) VALUES (:u, :p, 1)')
->execute([
'u' => $username,
'p' => $passHash,
]);
// Set the relay-wide super-shared key. This is the cross-tenant
// routing key — used by the relay to re-encrypt messages at rest.
setInterTenantKey($db, $MASTER_KEY, $superSecret);
$tenantId = (int)$db->lastInsertId();
$token = makeSession($db, $tenantId);
setSessionCookie($token);
jsonResponse(['ok' => true, 'username' => $username, 'is_admin' => true]);
}
// ── Public: login (UI session) ────────────────────────────────────
if ($route === '/api/login' && $method === 'POST') {
if (isRateLimited($db, 'login', 5)) jsonResponse(['error' => 'too many attempts'], 429);
$input = json_decode(file_get_contents('php://input'), true) ?: [];
$username = trim((string)($input['username'] ?? ''));
$password = (string)($input['password'] ?? '');
$tenant = getTenantByUsername($db, $username);
if (!$tenant || !password_verify($password, $tenant['password_hash'])) {
jsonResponse(['error' => 'wrong username or password'], 401);
}
$token = makeSession($db, (int)$tenant['id']);
setSessionCookie($token);
jsonResponse([
'ok' => true,
'username' => $tenant['username'],
'is_admin' => (bool)$tenant['is_admin'],
]);
}
if ($route === '/api/logout' && $method === 'POST') {
destroySession($db);
jsonResponse(['ok' => true]);
}
// ── Session-authenticated: /api/me ────────────────────────────────
$sessionTenant = getSessionTenant($db);
if ($route === '/api/me' && $method === 'GET') {
if (!$sessionTenant) jsonResponse(['error' => 'not logged in'], 401);
jsonResponse([
'username' => $sessionTenant['username'],
'is_admin' => (bool)$sessionTenant['is_admin'],
'created_at' => $sessionTenant['created_at'],
]);
}