Update development doc references
This commit is contained in:
1 parent
00ee563311
commit
8d296c963e
5 files changed
+10
-10
No files matched your search
@@ -2,7 +2,7 @@
|
||||
|
||||
Date: 2026-06-05
|
||||
|
||||
Source review: `dev_docs/security-review.md`
|
||||
Source review: `dev_docs/02_security-review.md`
|
||||
|
||||
## Goal
|
||||
|
||||
@@ -19,7 +19,7 @@ Close the security issues from the review without changing RUWIO's core authorin
|
||||
|
||||
Files likely touched:
|
||||
|
||||
- `dev_docs/security-review.md`
|
||||
- `dev_docs/02_security-review.md`
|
||||
- `package.json`
|
||||
- `server/package.json`
|
||||
- `server/server.js`
|
||||
|
||||
@@ -2,7 +2,7 @@
|
||||
|
||||
Date: 2026-06-05
|
||||
|
||||
This document supersedes `electron-rendering-integration-plan.md` for ongoing
|
||||
This document supersedes `04_electron-rendering-integration-plan.md` for ongoing
|
||||
work. It is self-contained: you do not need the original plan to continue from
|
||||
here. It records what is already implemented, what was found during review, and
|
||||
the concrete remaining TODOs in priority order.
|
||||
|
||||
@@ -2,7 +2,7 @@
|
||||
|
||||
Date: 2026-06-06
|
||||
|
||||
This document is a follow-on to `electron-rendering-integration-plan_2.md`.
|
||||
This document is a follow-on to `05_electron-rendering-integration-plan_2.md`.
|
||||
That plan tracked findings **#1–#6** (all resolved). A second review of the
|
||||
uncommitted desktop-render changes surfaced a new set of issues, numbered
|
||||
**#7–#13** here to avoid collision. Two of them (#7, #8) are user-facing data
|
||||
@@ -351,6 +351,6 @@ and/or a desktop check asserting a clean result instead of an ffmpeg crash.
|
||||
`*://*/*` network block (plan_2 #5) does not drop them — no action needed.
|
||||
|
||||
## Suggested doc bookkeeping
|
||||
When these land, update `electron-rendering-integration-plan_2.md`:
|
||||
When these land, update `05_electron-rendering-integration-plan_2.md`:
|
||||
- correct the "Partial output file is removed on failure/cancel" note (#7),
|
||||
- and `electron-rendering-manual-checks.md` with the new verify scripts.
|
||||
- and `06_electron-rendering-manual-checks.md` with the new verify scripts.
|
||||
@@ -12,7 +12,7 @@ It builds on what already exists — do not re-invent these:
|
||||
- the Node/Electron **render harnesses** (`scripts/verify-*.cjs`),
|
||||
- the **server** tests (`server/{server.smoke,render.e2e}.test.cjs`),
|
||||
- the **shared validation** unit tests (`shared/renderValidation.test.cjs`),
|
||||
- the manual checklist (`electron-rendering-manual-checks.md`).
|
||||
- the manual checklist (`06_electron-rendering-manual-checks.md`).
|
||||
|
||||
> **TL;DR**
|
||||
> 1. **Don't fork the suite per build.** The frontend is ~99% shared and gated
|
||||
@@ -321,7 +321,7 @@ Phased so each phase is independently valuable and CI-wireable.
|
||||
- A root `test` script aggregating the CI-safe layers, and a first
|
||||
`.github/workflows/test.yml` (matrix: lint/build, node `test:*`,
|
||||
`test:render-*` with ffmpeg/Chromium, Playwright browser + electron jobs).
|
||||
- Update `electron-rendering-manual-checks.md` to point at the new automated checks
|
||||
- Update `06_electron-rendering-manual-checks.md` to point at the new automated checks
|
||||
and list what still needs a HiDPI/macOS box (#10, D10).
|
||||
|
||||
### Proposed `package.json` scripts (final shape)
|
||||
@@ -361,6 +361,6 @@ Phased so each phase is independently valuable and CI-wireable.
|
||||
run under both hosts.
|
||||
- Driving real native OS menus / native save dialogs in automation (brittle); we use
|
||||
the IPC menu-fire hook and the dialog stub instead, and keep one **manual** pass in
|
||||
`electron-rendering-manual-checks.md` for true native behaviour and macOS roles (D10).
|
||||
`06_electron-rendering-manual-checks.md` for true native behaviour and macOS roles (D10).
|
||||
- The offscreen-rendering rewrite (deferred per the fix-plan); if it lands later,
|
||||
the §4 capture matrix is exactly the harness that re-validates it.
|
||||
@@ -1,4 +1,4 @@
|
||||
// Phase A verification harness (electron-rendering-integration-plan_2.md, finding #1/#2).
|
||||
// Phase A verification harness (05_electron-rendering-integration-plan_2.md, finding #1/#2).
|
||||
//
|
||||
// Reproduces renderWorker.cts's window-creation + capturePage path against a
|
||||
// scene with one moving + fading layer, then checks that captured frames are
|
||||
|
||||
Reference in new issue
Block a user