test fixes: dialog selector, closeAll scope, copy filter, runner ?v=3
* card-interactions.test.js: group delete tests used `.dialog-ok` (class selector) but the button has `id="dialog-ok"`. querySelector returned null, the click was skipped, the dialog stayed open and blocked every downstream test. Fixed to getElementById. * runner.js closeAll(): added #dialog, #bucket-super-popover (remove), and #gitea-overlay to the cleanup list. A failed test that leaves any of these open no longer poisons the rest of the suite. * runner.js copy handler: when there are failures or flaky tests, the "copy" button now builds the clipboard text from lastResults — only failed + flaky lines (suite name, test name, timing, error, original error for retried). When everything passed, copies the full output as before. lastResults is set in renderResults(). * bucket-context.test.js: move-left test used `[data-bucket]` to find user bucket tabs, which misses super-bucket tiles (they carry `data-bucket-super`). Changed to `[data-bucket-drag]` which is on both regular and super-bucket tiles but not on fixed filters. * context-menu.test.js: make-ticket pre-fill assertion now polls up to 2s for the title input to be populated (async openCreateForm repo-fetch was racing against the immediate assertion). * card-join.test.js: clickJoin sleep bumped from 400ms → 800ms. joinSelectedCards does 3+ serial API calls (fetch bodies, PATCH winner, N×DELETE losers, _reloadAll) which sometimes exceeded the old 400ms window on slow runs. * Runner cache: RUNNER_V bumped from ?v=2 → ?v=3 in loader.js + all 42 test files so the browser picks up the new runner.js content (copy handler, closeAll, retry progress bar) without a hard reload. super-buckets: remember last selection per group * buckets.js: module-scope lastSuperSelection Map tracks the last active member per super-bucket parent. Updated in renderBar() whenever activeBucket matches a group member. tileFor() uses it as a fallback when the user is on a different bucket — the tile shows the last-picked child's name and color instead of reverting to the parent. The dropdown popover also highlights the last selection when no member is currently active. chore: bump version to 0.9.11 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
1 parent
56c90225cb
commit
c8835825e7
47 files changed
+126
-56
No files matched your search
@@ -242,6 +242,12 @@ function updateHeaderTint() {
|
||||
}
|
||||
}
|
||||
|
||||
// Remembers the last active member per super-bucket so the tile doesn't
|
||||
// fall back to the parent label when the user navigates away and comes
|
||||
// back. Keyed by parent bucket id → last selected member id (could be
|
||||
// the parent itself or any child).
|
||||
const lastSuperSelection = new Map();
|
||||
|
||||
function renderBar() {
|
||||
if (!bar) return;
|
||||
const tab = (active) => `bucket-tab ${active ? 'active' : ''} flex items-center gap-1.5 px-2.5 py-1 text-xs border border-t-border text-t-muted hover:border-t-accent hover:text-t-accent transition-colors shrink-0`;
|
||||
@@ -253,14 +259,31 @@ function renderBar() {
|
||||
.filter(b => b.parent_id == parentId)
|
||||
.sort((a, b) => (a.position || 0) - (b.position || 0));
|
||||
|
||||
// Resolve which child / parent to *show* on a super-bucket tile. The
|
||||
// active bucket wins; otherwise fall back to the parent itself.
|
||||
// Track which super-bucket member is active NOW so we can recall it
|
||||
// later when the user comes back from a different bucket.
|
||||
for (const b of topLevel) {
|
||||
const kids = childrenOf(b.id);
|
||||
if (!kids.length) continue;
|
||||
if (state.activeBucket == b.id) lastSuperSelection.set(b.id, b.id);
|
||||
const activeKid = kids.find(c => c.id == state.activeBucket);
|
||||
if (activeKid) lastSuperSelection.set(b.id, activeKid.id);
|
||||
}
|
||||
|
||||
// Resolve which child / parent to *show* on a super-bucket tile.
|
||||
// Priority: currently active member → last selected member → parent.
|
||||
const tileFor = (parent) => {
|
||||
const kids = childrenOf(parent.id);
|
||||
if (!kids.length) return null; // not a super-bucket
|
||||
const activeChild = kids.find(c => c.id == state.activeBucket);
|
||||
if (activeChild) return activeChild;
|
||||
if (state.activeBucket == parent.id) return parent;
|
||||
// Fall back to the last selection rather than the parent
|
||||
const lastId = lastSuperSelection.get(parent.id);
|
||||
if (lastId) {
|
||||
if (lastId == parent.id) return parent;
|
||||
const lastKid = kids.find(c => c.id == lastId);
|
||||
if (lastKid) return lastKid;
|
||||
}
|
||||
return parent;
|
||||
};
|
||||
|
||||
@@ -369,9 +392,13 @@ function renderBar() {
|
||||
pop.style.top = (rect.bottom + 4) + 'px';
|
||||
pop.style.left = rect.left + 'px';
|
||||
|
||||
// Highlight the currently active member OR the last remembered
|
||||
// selection (so the user sees which child was picked last time
|
||||
// even when they're currently on a different bucket).
|
||||
const lastId = lastSuperSelection.get(parentId);
|
||||
const renderEntry = (m) => {
|
||||
const c = m.color || '#64748b';
|
||||
const active = state.activeBucket == m.id;
|
||||
const active = state.activeBucket == m.id || (!members.some(x => x.id == state.activeBucket) && lastId == m.id);
|
||||
const isParent = m.id === parentId;
|
||||
return `<button class="bucket-tab ${active ? 'active' : ''} flex items-center gap-1.5 px-2.5 py-1 text-xs border border-t-border text-t-muted hover:border-t-accent hover:text-t-accent transition-colors w-full" data-bucket="${m.id}" draggable="true" data-bucket-drag="${m.id}" style="border-left:3px solid ${c};${active ? `background:${c};color:var(--t-bg);border-color:${c}` : ''}"><i class="ph ph-folder text-sm"></i><span class="font-pixel text-[10px] flex-1 text-left">${esc(m.name)}</span>${isParent ? '<i class="ph ph-house text-[10px] opacity-60" title="parent"></i>' : ''}</button>`;
|
||||
};
|
||||
|
||||
Reference in new issue
Block a user