th/hyprcrd
3
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(shopping): remove old flat-list li styles causing visual doubling

Browse Source 
.shopping-items li was the old single-list item rule. After the
multi-list refactor, the direct children of .shopping-items are
<li class="shopping-list-box"> wrappers, not individual items.
The old rule gave the box the same background + border + padding +
tap-target as the .shopping-item divs inside it — making each list
look like it appeared twice.

Drop the generic li rule entirely. Items are styled via
.shopping-item, boxes via .shopping-list-box, empty state via
.shopping-items .empty. Also dedup by card_uid in loadShopping JS
as a safety net.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
thandClaude Opus 4.6 committed 2026-04-16 17:35:27 +02:00
1 parent 59be08a8f8
commit 5c9e9254d1
2 files changed
+10 -11
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

relay/ui/app.js
+8 -1
View File
@@ -773,7 +773,14 @@ async function loadShopping(quiet = false) {
const list = $('shopping-items'); const list = $('shopping-items');
if (!list) return; if (!list) return;
if (!data?.ok) { if (!quiet) shoppingErr(data?.error || 'load failed'); return; } if (!data?.ok) { if (!quiet) shoppingErr(data?.error || 'load failed'); return; }
const lists = data.lists || []; // Dedup by card_uid — belt and suspenders in case the relay DB
// has stale rows from earlier schema migrations.
const seen = new Set();
const lists = (data.lists || []).filter(l => {
if (seen.has(l.card_uid)) return false;
seen.add(l.card_uid);
return true;
});
if (!lists.length) { if (!lists.length) {
if (title) title.textContent = 'Shopping'; if (title) title.textContent = 'Shopping';
list.innerHTML = '<li class="empty">no active shopping lists</li>'; list.innerHTML = '<li class="empty">no active shopping lists</li>';
relay/ui/style.css
+2 -10
View File
@@ -267,16 +267,8 @@ label.checkbox input[type="checkbox"] { accent-color:var(--accent); cursor:point
unchecked items only, tap to flip. */ unchecked items only, tap to flip. */
.shopping-wrap { max-width: 520px; margin: 0 auto; display: flex; flex-direction: column; gap: 12px; } .shopping-wrap { max-width: 520px; margin: 0 auto; display: flex; flex-direction: column; gap: 12px; }
.shopping-top { display: flex; align-items: center; gap: 10px; padding: 6px 2px; } .shopping-top { display: flex; align-items: center; gap: 10px; padding: 6px 2px; }
.shopping-items { list-style: none; padding: 0; margin: 0; display: flex; flex-direction: column; gap: 6px; } .shopping-items { list-style: none; padding: 0; margin: 0; display: flex; flex-direction: column; gap: 10px; }
.shopping-items li { .shopping-items .empty { list-style: none; text-align: center; padding: 40px 16px; color: var(--dim); background: transparent; border: none; cursor: default; }
background: var(--surface); border: 1px solid var(--border); border-radius: var(--radius-lg);
padding: 14px 16px; font-size: 16px; cursor: pointer; user-select: none;
-webkit-tap-highlight-color: transparent;
transition: transform 0.12s, opacity 0.3s, background 0.12s;
}
.shopping-items li:active { transform: scale(0.98); background: var(--raised, var(--surface)); }
.shopping-items li.checked { opacity: 0.35; text-decoration: line-through; }
.shopping-items .empty { text-align: center; padding: 40px 16px; color: var(--dim); background: transparent; border: none; cursor: default; list-style: none; }
.shopping-items .empty:active { transform: none; } .shopping-items .empty:active { transform: none; }
/* Multi-list stacked boxes */ /* Multi-list stacked boxes */