th/RUWIO

0 Fork 0

Files

T

thandClaude Opus 4.8 518d43855b Add desktop/server MP4 export pipeline, hardening, and render tests (v1.3.0)

Desktop MP4 export renders frames from a hidden BrowserWindow via
capturePage, pipes PNGs to a bundled ffmpeg (libx264/yuv420p/+faststart),
and writes the file through an atomic temp-file swap. It shares scene
validation (shared/renderValidation.cjs) and the render.html renderer with
the standalone Puppeteer server, which is hardened in parallel.

Render worker & main (electron/):
- abortable render loop with an inactivity watchdog and cancel plumbing
- atomic temp-file + rename so a cancel/failure never truncates a
  pre-existing target (#7); stdin EPIPE / early-exit / backpressure-hang
  handled (#8)
- HiDPI frames normalized to canvas size (#10); odd dimensions padded to
  even (#13, also server); backgroundThrottling disabled (#12)
- reject canvases larger than the display (#11); single-render guard;
  isolated render session that blocks network requests (#5)

Tests:
- Electron harnesses (scripts/verify-*.cjs) for capture, export, cancel,
  timeout, assets, background, capture-fidelity, resolution, odd-dims,
  aggregated by verify-desktop-render.cjs
- server smoke + e2e and shared validation unit tests
- headless hook (src/devtools/headless.ts) to run the in-app suite under
  browser/electron hosts; pixel-diff util + capture fixtures (test/)
- dev_docs plans: integration, fixes (#7-#13), and the e2e/capture strategy

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

2026-06-06 20:41:25 +02:00

3.1 KiB

Raw Blame History

Electron MP4 Render Manual Checks

Date: 2026-06-05

Use this checklist before treating desktop MP4 export as release-ready.

Automated Desktop Render Checks

Before the manual checks below, run the headless harness suite (requires a display, ffmpeg, and ffprobe). It drives the real worker end-to-end and covers frame capture, MP4 output, cancel, the inactivity watchdog, the render-window network block, and transparent-region flattening:

npm run test:render-desktop

All six checks should print RESULT: PASS and the run ends with ALL DESKTOP RENDER CHECKS PASSED.

Build Checks

Stage a redistributable ffmpeg binary for the target platform:
```
npm run stage:ffmpeg -- --source /path/to/ffmpeg
```
Build an unpacked app:
```
npm run desktop:pack
```

Confirm packaged resources exist:

find release/linux-unpacked/resources -maxdepth 4 -type f | sort | rg 'server/render.html|bin/.*/ffmpeg'

Confirm Unix executable permissions on Linux/macOS:

ls -l release/linux-unpacked/resources/bin/linux/ffmpeg

Confirm the packaged binary runs:

release/linux-unpacked/resources/bin/linux/ffmpeg -version

App Checks

Launch the unpacked app.
Create a tiny scene with at least one visible animated layer.
Export MP4 at the default FPS and confirm:
- a native save dialog appears
- progress advances in the export dialog
- the final file exists at the selected path
- the file opens in a standard media player
Start another MP4 export and cancel after progress starts. Confirm:
- progress stops
- the app remains responsive
- no partial MP4 remains at the selected path
Repeat with:
- image assets
- text layers using non-default fonts
- non-default FPS
- layers hidden from render

Server Fallback Checks

Automated route smoke:

npm run test:render-server

Automated MP4 E2E smoke:

npm run test:render-server:e2e

The E2E smoke starts the standalone server on a temporary localhost port, submits a tiny scene, waits for SSE completion, downloads the MP4, and verifies the H.264 stream with ffprobe. It requires Chromium, ffmpeg, and ffprobe.

Manual browser fallback:

Start the standalone server:

cd server
HOST=127.0.0.1 PORT=6000 RENDER_TOKEN="choose-a-long-random-token" npm start

Start the browser app with matching render settings:

VITE_RENDER_SERVER=http://localhost:6000 VITE_RENDER_TOKEN="choose-a-long-random-token" npm run dev

Export MP4 from the browser app and confirm the server path still works.

ffmpeg Release Notes

For every bundled ffmpeg binary, record:

source URL
upstream version
target platform and architecture
whether the build is static or dynamically linked
configured codecs, especially libx264
GPL/LGPL license obligations
required attribution or license files to ship with the app

The local staging script may copy a system ffmpeg. That is useful for package path verification, but release artifacts should use reviewed redistributable binaries for each platform.

3.1 KiB Raw Blame History